build: upgrade to nodejs v18 (#254)

Uniswap · Sep 8, 2023 · ce73698 · ce73698
1 parent 9e3a60a
commit ce73698
Show file tree

Hide file tree

Showing 7 changed files with 112 additions and 165 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -16,9 +16,9 @@ jobs:
         uses: actions/checkout@v2
 
       - name: Set up node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
           registry-url: https://registry.npmjs.org
 
       - name: Install dependencies

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -16,9 +16,9 @@ jobs:
         uses: actions/checkout@v2
 
       - name: Set up node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
           registry-url: https://registry.npmjs.org
 
       - name: Install dependencies

diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+18.17.1
diff --git a/bin/app.ts b/bin/app.ts
@@ -57,7 +57,7 @@ export class APIPipeline extends Stack {
     const synthStep = new CodeBuildStep('Synth', {
       input: code,
       buildEnvironment: {
-        buildImage: cdk.aws_codebuild.LinuxBuildImage.STANDARD_6_0,
+        buildImage: cdk.aws_codebuild.LinuxBuildImage.STANDARD_7_0,
         environmentVariables: {
           NPM_TOKEN: {
             value: 'npm-private-repo-access-token',
@@ -83,7 +83,7 @@ export class APIPipeline extends Stack {
         phases: {
           install: {
             'runtime-versions': {
-              nodejs: '16',
+              nodejs: '18',
             },
           },
         },
@@ -130,8 +130,7 @@ export class APIPipeline extends Stack {
     });
 
     const syntheticSwitchApiKeySecret = sm.Secret.fromSecretAttributes(this, 'synthetic-switch-api-key', {
-      secretCompleteArn:
-        'arn:aws:secretsmanager:us-east-2:644039819003:secret:UniswapX/ParamApi/ApiKeys-hYyUt1',
+      secretCompleteArn: 'arn:aws:secretsmanager:us-east-2:644039819003:secret:UniswapX/ParamApi/ApiKeys-hYyUt1',
     });
 
     // Beta us-east-2
@@ -209,7 +208,7 @@ export class APIPipeline extends Stack {
         UNISWAP_API: apiStage.url,
       },
       buildEnvironment: {
-        buildImage: cdk.aws_codebuild.LinuxBuildImage.STANDARD_6_0,
+        buildImage: cdk.aws_codebuild.LinuxBuildImage.STANDARD_7_0,
         environmentVariables: {
           NPM_TOKEN: {
             value: 'npm-private-repo-access-token',
@@ -248,7 +247,7 @@ export class APIPipeline extends Stack {
         phases: {
           install: {
             'runtime-versions': {
-              nodejs: '16',
+              nodejs: '18',
             },
           },
         },

diff --git a/bin/stacks/api-stack.ts b/bin/stacks/api-stack.ts
@@ -174,7 +174,7 @@ export class APIStack extends cdk.Stack {
     });
     const quoteLambda = new aws_lambda_nodejs.NodejsFunction(this, 'Quote', {
       role: lambdaRole,
-      runtime: aws_lambda.Runtime.NODEJS_16_X,
+      runtime: aws_lambda.Runtime.NODEJS_18_X,
       entry: path.join(__dirname, '../../lib/handlers/index.ts'),
       handler: 'quoteHandler',
       memorySize: 1024,
@@ -189,7 +189,7 @@ export class APIStack extends cdk.Stack {
         ...props.envVars,
       },
       timeout: cdk.Duration.seconds(30),
-      logRetention: aws_logs.RetentionDays.ONE_MONTH
+      logRetention: aws_logs.RetentionDays.ONE_MONTH,
     });
 
     const quoteLambdaAlias = new aws_lambda.Alias(this, `GetOrdersLiveAlias`, {
@@ -212,7 +212,7 @@ export class APIStack extends cdk.Stack {
       quoteTarget.scaleToTrackMetric('QuoteProvConcTracking', {
         targetValue: 0.8,
         predefinedMetric: aws_asg.PredefinedMetric.LAMBDA_PROVISIONED_CONCURRENCY_UTILIZATION,
-      })
+      });
     }
 
     /* Analytics */

diff --git a/package.json b/package.json
@@ -70,9 +70,8 @@
     "@uniswap/smart-order-router": "3.15.2",
     "@uniswap/uniswapx-sdk": "1.1.0",
     "@uniswap/universal-router-sdk": "^1.5.7",
-    "aws-cdk-lib": "2.43.1",
+    "aws-cdk-lib": "2.85.0",
     "aws-embedded-metrics": "^4.1.0",
-    "aws-sdk": "^2.1238.0",
     "axios": "^1.2.1",
     "axios-retry": "^3.4.0",
     "bunyan": "^1.8.15",