Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Expose enableFeeOnTransferFeeFetching post request field #260

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Sep 8, 2023

Interface already fetches fee-on-transfer tax and shave off the quote amount. We need to protect smart-order-router fee-on-transfer tax feature under a feature flag, so that interface doesn't double FOT tax.

Routing-api corresponding PR Uniswap/routing-api#361

Tested via:

curl 'https://ggy7t0yp57.execute-api.us-east-2.amazonaws.com/prod/quote' \
  --data-raw '{
   "tokenInChainId":1,
   "tokenIn":"0x0D0A1767da735F725f41c4315E072c63Dbc6ab3D",
   "tokenOutChainId":1,
   "tokenOut":"0xab98093c7232e98a47d7270ce0c1c2106f61c73b",
   "amount":"1000000000000000000",
   "type":"EXACT_INPUT",
   "configs":[
      {
         "protocols":[
            "V2",
            "V3",
            "MIXED"
         ],
         "routingType":"CLASSIC",
         "unicornSecret":"MASKED",
         "debugRoutingConfig": "{\"debugRouting\":true}",
         "enableFeeOnTransferFeeFetching": true
       }
   ]
}'

Can see enableFeeOnTransferFeeFetching passing through routing-api until smart-order-router in personal AWS logging insights:
Screenshot 2023-09-08 at 12 37 07 PM

@jsy1218 jsy1218 self-assigned this Sep 8, 2023
@jsy1218 jsy1218 force-pushed the jsy1218/enable-token-properties-provider-flag branch from 3687bc1 to da2b3fc Compare September 11, 2023 07:18
@jsy1218 jsy1218 merged commit 020ea37 into main Sep 11, 2023
4 checks passed
@jsy1218 jsy1218 deleted the jsy1218/enable-token-properties-provider-flag branch September 11, 2023 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants