fix: lint and add linter to CI

Somehow linter never got added to CI here so we've gone off the rails

.github/workflows/lint.yml

@@ -0,0 +1,30 @@
+name: Lint
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  run-linters:
+    name: lint
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out Git repository
+        uses: actions/checkout@v2
+
+      - name: Set up node
+        uses: actions/setup-node@v3
+        with:
+          node-version: 18.x
+          registry-url: https://registry.npmjs.org
+
+      - name: Install dependencies
+        run: |
+          npm config set '//registry.npmjs.org/:_authToken' "${{ secrets.NPM_AUTH_TOKEN }}" \
+          && yarn install --frozen-lockfile
+
+      - name: Run linters
+        run: yarn lint

lib/entities/QuoteRequest.ts

@@ -89,15 +89,15 @@ export class QuoteRequest {
       ...(this.quoteId && { quoteId: this.quoteId }),
     };
   }
-  
+
   public toOpposingRequest(): QuoteRequest {
     const opposingJSON = this.toOpposingCleanJSON();
     return new QuoteRequest({
       ...opposingJSON,
       amount: BigNumber.from(opposingJSON.amount),
       type: TradeType[opposingJSON.type as keyof typeof TradeType],
     });
-}
+  }
 
   public get requestId(): string {
     return this.data.requestId;

lib/entities/analytics-events.ts

@@ -1,9 +1,10 @@
 import { v4 as uuidv4 } from 'uuid';
+
 import { timestampInMstoISOString } from '../util/time';
 
 export enum AnalyticsEventType {
   WEBHOOK_RESPONSE = 'WebhookQuoterResponse',
-};
+}
 
 export enum WebhookResponseType {
   OK = 'OK',
@@ -13,7 +14,7 @@ export enum WebhookResponseType {
   TIMEOUT = 'TIMEOUT',
   HTTP_ERROR = 'HTTP_ERROR',
   OTHER_ERROR = 'OTHER_ERROR',
-};
+}
 
 export class AnalyticsEvent {
   eventId: string; // gets set in constructor
@@ -27,4 +28,4 @@ export class AnalyticsEvent {
     this.eventTime = timestampInMstoISOString(Date.now());
     this.eventProperties = eventProperties;
   }
-};
+}

lib/entities/index.ts

@@ -1,4 +1,4 @@
+export * from './analytics-events';
 export * from './aws-metrics-logger';
 export * from './QuoteRequest';
 export * from './QuoteResponse';
-export * from './analytics-events';

lib/handlers/quote/injector.ts

@@ -10,8 +10,8 @@ import {
   FADE_RATE_BUCKET,
   FADE_RATE_S3_KEY,
   INTEGRATION_S3_KEY,
-  PRODUCTION_S3_KEY,
   PROD_COMPLIANCE_S3_KEY,
+  PRODUCTION_S3_KEY,
   WEBHOOK_CONFIG_BUCKET,
 } from '../../constants';
 import {

lib/providers/analytics/firehose.ts

@@ -1,8 +1,8 @@
 import { FirehoseClient, PutRecordCommand } from '@aws-sdk/client-firehose';
 import { default as Logger } from 'bunyan';
 
-import { IAnalyticsLogger } from '.';
 import { AnalyticsEvent } from '../../entities/analytics-events';
+import { IAnalyticsLogger } from '.';
 
 export class FirehoseLogger implements IAnalyticsLogger {
   private log: Logger;

lib/providers/compliance/index.ts

@@ -5,7 +5,7 @@ export interface FillerComplianceConfiguration {
 
 export interface FillerComplianceConfigurationProvider {
   getConfigs(): Promise<FillerComplianceConfiguration[]>;
- // getExcludedAddrToEndpointsMap(): Promise<Map<string, Set<string>>>;
+  // getExcludedAddrToEndpointsMap(): Promise<Map<string, Set<string>>>;
   getEndpointToExcludedAddrsMap(): Promise<Map<string, Set<string>>>;
 }
 

lib/providers/compliance/mock.ts

@@ -6,7 +6,7 @@ export class MockFillerComplianceConfigurationProvider implements FillerComplian
   async getConfigs(): Promise<FillerComplianceConfiguration[]> {
     return this.configs;
   }
-  
+
   async getEndpointToExcludedAddrsMap(): Promise<Map<string, Set<string>>> {
     const map = new Map<string, Set<string>>();
     this.configs.forEach((config) => {
@@ -18,8 +18,7 @@ export class MockFillerComplianceConfigurationProvider implements FillerComplian
           map.get(endpoint)?.add(address);
         });
       });
-    })
+    });
     return map;
   }
-
-}
+}

lib/providers/compliance/s3.ts

@@ -1,11 +1,9 @@
-
 import { GetObjectCommand, S3Client } from '@aws-sdk/client-s3';
 import { default as Logger } from 'bunyan';
 
 import { checkDefined } from '../../preconditions/preconditions';
 import { FillerComplianceConfiguration, FillerComplianceConfigurationProvider } from '.';
 
-
 export class S3FillerComplianceConfigurationProvider implements FillerComplianceConfigurationProvider {
   private log: Logger;
   private configs: FillerComplianceConfiguration[];
@@ -32,14 +30,12 @@ export class S3FillerComplianceConfigurationProvider implements FillerCompliance
           this.endpointToExcludedAddrsMap.get(endpoint)?.add(address);
         });
       });
-    })
+    });
     return this.endpointToExcludedAddrsMap;
   }
 
   async getConfigs(): Promise<FillerComplianceConfiguration[]> {
-    if (
-      this.configs.length === 0
-    ) {
+    if (this.configs.length === 0) {
       await this.fetchConfigs();
     }
     return this.configs;
@@ -57,4 +53,4 @@ export class S3FillerComplianceConfigurationProvider implements FillerCompliance
     this.configs = JSON.parse(await s3Body.transformToString()) as FillerComplianceConfiguration[];
     this.log.info({ configsLength: this.configs.map((c) => c.addresses.length) }, `Fetched configs`);
   }
-}
+}

lib/quoters/MockQuoter.ts

@@ -1,8 +1,8 @@
 import Logger from 'bunyan';
 import { BigNumber } from 'ethers';
 
-import { Quoter, QuoterType } from '.';
 import { QuoteRequest, QuoteResponse } from '../entities';
+import { Quoter, QuoterType } from '.';
 
 export const MOCK_FILLER_ADDRESS = '0x0000000000000000000000000000000000000001';
 

test/entities/QuoteRequest.test.ts

@@ -53,7 +53,7 @@ describe('QuoteRequest', () => {
       numOutputs: 1,
     });
   });
-  
+
   it('toOpposingRequest', async () => {
     const opposingRequest = request.toOpposingRequest();
     expect(opposingRequest.toCleanJSON()).toEqual({