Merge pull request #307 from Uniswap/fix-try-catch

fix: try catch in handler instead
Uniswap · Apr 11, 2024 · c6cd013 · c6cd013
2 parents 342e9bf + e28b29a
commit c6cd013
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 26 deletions.
diff --git a/lib/handlers/hard-quote/handler.ts b/lib/handlers/hard-quote/handler.ts
@@ -102,20 +102,20 @@ export class QuoteHandler extends APIGLambdaHandler<
       metric.putMetric(Metric.QUOTE_POST_ATTEMPT, 1, MetricLoggerUnit.Count);
       // if no quote and creating open order, create random new quoteId
       await orderServiceProvider.postOrder(cosignedOrder, request.innerSig, bestQuote?.quoteId ?? uuidv4());
+      metric.putMetric(Metric.QUOTE_200, 1, MetricLoggerUnit.Count);
+      metric.putMetric(Metric.QUOTE_LATENCY, Date.now() - start, MetricLoggerUnit.Milliseconds);
+      const response = new HardQuoteResponse(request, cosignedOrder);
+
+      return {
+        statusCode: 200,
+        body: response.toResponseJSON(),
+      };
     } catch (e) {
+      log.error({ error: e }, 'Error posting order');
       metric.putMetric(Metric.QUOTE_400, 1, MetricLoggerUnit.Count);
       metric.putMetric(Metric.QUOTE_POST_ERROR, 1, MetricLoggerUnit.Count);
       throw new OrderPostError();
     }
-
-    metric.putMetric(Metric.QUOTE_200, 1, MetricLoggerUnit.Count);
-    metric.putMetric(Metric.QUOTE_LATENCY, Date.now() - start, MetricLoggerUnit.Milliseconds);
-    const response = new HardQuoteResponse(request, cosignedOrder);
-
-    return {
-      statusCode: 200,
-      body: response.toResponseJSON(),
-    };
   }
 
   protected requestBodySchema(): Joi.ObjectSchema | null {

diff --git a/lib/providers/order/uniswapxService.ts b/lib/providers/order/uniswapxService.ts
@@ -20,22 +20,17 @@ export class UniswapXServiceProvider implements OrderServiceProvider {
     const axiosConfig = {
       timeout: ORDER_SERVICE_TIMEOUT_MS,
     };
-
-    try {
-      await axios.post(
-        `${this.uniswapxServiceUrl}dutch-auction/order`,
-        {
-          encodedOrder: order.serialize(),
-          signature: signature,
-          chainId: order.chainId,
-          quoteId: quoteId,
-          orderType: V2_ORDER_TYPE,
-        },
-        axiosConfig
-      );
-      this.log.info({ orderHash: order.hash() }, 'Order posted to UniswapX Service');
-    } catch (e) {
-      this.log.error({ error: e }, 'Error posting order to UniswapX Service');
-    }
+    await axios.post(
+      `${this.uniswapxServiceUrl}dutch-auction/order`,
+      {
+        encodedOrder: order.serialize(),
+        signature: signature,
+        chainId: order.chainId,
+        quoteId: quoteId,
+        orderType: V2_ORDER_TYPE,
+      },
+      axiosConfig
+    );
+    this.log.info({ orderHash: order.hash() }, 'Order posted to UniswapX Service');
   }
 }