add hard quote #270
add hard quote #270
Conversation
marktoda
commented
Feb 22, 2024
marktoda
commented
- feat: add hard quote initial
- fix: tests
this commit adds the initial data required for hard quotes - hard quote entity and schema - hard quote basic handler
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
marktoda
force-pushed
the
add-hard-quote
branch
from
2eca92b to
d6a7d80
Compare
marktoda
force-pushed
the
add-hard-quote
branch
from
d6a7d80 to
3b1797c
Compare
| // switch tradeType | ||
| type: TradeType[type], | ||
| numOutputs: this.numOutputs, | ||
| ...(this.quoteId && { quoteId: this.quoteId }), |
There was a problem hiding this comment.
should we change quoteId? Otherwise first quoteId = real quote?
There was a problem hiding this comment.
keeping same semantics as the v1 quote, interesting point tho - I think quoters can disintermediate it themselves by storing both quotes under same quoteId and assuming only one or the other will end up as an order
| encodedInnerOrder: Joi.string().required(), | ||
| innerSig: FieldValidator.rawSignature.required(), | ||
| tokenInChainId: FieldValidator.chainId.required(), | ||
| tokenOutChainId: Joi.number().integer().valid(Joi.ref('tokenInChainId')).required(), |
There was a problem hiding this comment.
nit: why can't we do FieldValidator.chainId here too?
There was a problem hiding this comment.
this is a superset of the validation, since tokenInChainId runs checks first and this one ensures it's the same as tokenIn. if we did chainId for both then it would be valid to pass in separate values
|
|
||
| // A Raw Signature is a common Signature format where the r, s and v | ||
| // are concatenated into a 65 byte(130 nibble) DataHexString | ||
| public static readonly rawSignature = Joi.string().custom((value: string, helpers: CustomHelpers<string>) => { |
There was a problem hiding this comment.
nit: i thought sig length details were handled under the hood by ethers?
There was a problem hiding this comment.
they are, but that wouldn't throw a nice early validation result - we do this for several things, put a coarse validation check in joi so it catches obvious errors early
