add hard quote logic #271
Merged
add hard quote logic #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse order, run secondary quote, and cosign order
zhongeric
approved these changes
Feb 28, 2024
| @@ -76,16 +80,24 @@ export class HardQuoteRequest { | |||
| return utils.getAddress(this.order.info.baseOutputs[0].token); | |||
| } | |||
|
|
|||
| public get totalOutputAmountStart(): BigNumber { | |||
| let amount = BigNumber.from(0); | |||
| for (const output of this.order.info.baseOutputs) { | |||
There was a problem hiding this comment.
this assumes all outputs are same token which is not necessarily true right?
There was a problem hiding this comment.
Assumed true anyways for now in main rfq flownsince quoters can only be for one token
| const outputAmounts = request.order.info.baseOutputs.map(() => BigNumber.from(0)); | ||
|
|
||
| // if the quote is better, then increase amounts by the difference | ||
| if (request.type === TradeType.EXACT_INPUT) { |
There was a problem hiding this comment.
What's the expected behavior if less outputs are required for EXACT_INPUT but more input is required? Apply the output adjustment but not the input? Wonder if we should explicitly throw / error on this case if its undesired behavior
There was a problem hiding this comment.
Hmm interesting, I think the api contract should disallow changing the EXACT_X side in any case yea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the internal logic for hard quotes! Effectively:
Still remaining TODOs: