feat: separate hard quote exports #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConjunctiveNormalForm
approved these changes
Mar 8, 2024
previously hard quote injector was built in the same index exports file as the indicative quote injector, causing even indicative quote setup to require a KMS_KEY_ID environment variable. This commit separates the export into a separate file to decouple the env pulling. Future improvement should do this same separation for rest of the lambdas as well instead of having a global handlers/index
marktoda
force-pushed
the
separate-hard-quote-exports
branch
from
28219bc to
ea9664d
Compare
marktoda
commented
Mar 8, 2024
| @@ -0,0 +1,9 @@ | |||
| import { QuoteHandler } from './handler'; | |||
There was a problem hiding this comment.
had to move out of index.ts else the injector/handler would be built from unit tests, requiring env variables etc. whenever we do `import { QuoteHandler } from 'hard-quote';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously hard quote injector was built in the same index exports file
as the indicative quote injector, causing even indicative quote setup to
require a KMS_KEY_ID environment variable. This commit separates the
export into a separate file to decouple the env pulling.
Future improvement should do this same separation for rest of the
lambdas as well instead of having a global handlers/index