Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard dimensions and filler names #339

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix: dashboard dimensions and filler names #339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf768d5
fix dashboard dimensions and filelr names
ConjunctiveNormalForm Jun 10, 2024
ad7eabf
typo
ConjunctiveNormalForm Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions bin/stacks/param-dashboard-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import { Construct } from 'constructs';

import {
CircuitBreakerMetricDimension,
HardQuoteMetricDimension,
Metric,
SoftQuoteMetricDimension,
UniswapXParamServiceMetricDimension,
} from '../../lib/entities';

export const NAMESPACE = 'Uniswap';
Expand Down Expand Up @@ -47,7 +47,7 @@ export type LambdaWidget = {
};
};

const RFQ_SERVICES = [SoftQuoteMetricDimension, UniswapXParamServiceMetricDimension];
const RFQ_SERVICES = [SoftQuoteMetricDimension, HardQuoteMetricDimension];

const LatencyWidget = (region: string): LambdaWidget[] =>
RFQ_SERVICES.map((service) => {
Expand All @@ -65,7 +65,7 @@ const LatencyWidget = (region: string): LambdaWidget[] =>
stacked: false,
region,
period: 300,
title: 'Quote Latency | 5 minutes',
title: `${service.Service} Quote Latency | 5 minutes`,
},
};
});
Expand All @@ -89,7 +89,7 @@ const RFQLatencyWidget = (region: string, rfqProviders: string[]): LambdaWidget[
region,
stat: 'p90',
period: 300,
title: 'RFQ Response Times P90 | 5 minutes',
title: `${service.Service} RFQ Response Times P90 | 5 minutes`,
},
};
});
Expand All @@ -112,7 +112,7 @@ const QuotesRequestedWidget = (region: string): LambdaWidget[] =>
stat: 'Sum',
period: 300,
stacked: false,
title: 'Quotes Requested | 5 minutes',
title: `${service.Service} Quotes Requested | 5 minutes`,
},
};
});
Expand All @@ -138,7 +138,7 @@ const ErrorRatesWidget = (region: string): LambdaWidget[] =>
region,
stat: 'Sum',
period: 300,
title: 'Error Rates',
title: `${service.Service} Error Rates`,
yAxis: {
left: {
label: 'Percent',
Expand Down Expand Up @@ -216,7 +216,7 @@ const RFQFailRatesWidget = (region: string, rfqProviders: string[]): LambdaWidge
region,
stat: 'Sum',
period: 300,
title: 'RFQ Fail Rates',
title: `${service.Service} RFQ Fail Rates`,
yAxis: {
left: {
label: 'Percent',
Expand Down Expand Up @@ -256,7 +256,20 @@ export interface DashboardProps extends cdk.NestedStackProps {
}

// TODO: fetch dynamically from s3?
const RFQ_PROVIDERS = ['A', 'B', 'C', 'D', 'E', 'F'];
const RFQ_PROVIDERS = [
'Barter',
'Wintermute',
'Kodea',
'Flow Traders - Validation',
'Flow Traders',
'ODOS',
'Pear',
'Altonomy',
'SCP',
'Propellerheads',
'Clipper',
'Prycto V2',
];

export class ParamDashboardStack extends cdk.NestedStack {
constructor(scope: Construct, name: string, props: DashboardProps) {
Expand Down
Loading