chore: improve log readability

Uniswap · Nov 9, 2023 · 794eb24 · 794eb24
1 parent 6a4f732
commit 794eb24
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/handlers/order-notification/handler.ts b/lib/handlers/order-notification/handler.ts
@@ -29,6 +29,8 @@ export class OrderNotificationHandler extends DynamoStreamLambdaHandler<Containe
           filler: newOrder.filler,
         })
 
+        log.info({ order: newOrder, registeredEndpoints }, 'Sending order to registered webhooks.')
+
         const requests: Promise<AxiosResponse>[] = registeredEndpoints.map((endpoint) =>
           axios.post(
             endpoint.url,
@@ -58,6 +60,7 @@ export class OrderNotificationHandler extends DynamoStreamLambdaHandler<Containe
         results.forEach((result, index) => {
           metrics.putMetric(`OrderNotificationAttempt-chain-${newOrder.chainId}`, 1)
           if (result.status == 'fulfilled' && result?.value?.status >= 200 && result?.value?.status <= 202) {
+            delete result.value.request
             log.info(
               { result: result.value },
               `Success: New order record sent to registered webhook ${registeredEndpoints[index].url}.`

diff --git a/test/handlers/order-notification.test.ts b/test/handlers/order-notification.test.ts
@@ -92,7 +92,7 @@ describe('Testing new order Notification handler.', () => {
       orderStatus: MOCK_ORDER.orderStatus.S,
       filler: MOCK_ORDER.filler.S,
     })
-    expect(logInfoMock).toBeCalledTimes(2)
+    expect(logInfoMock).toBeCalledTimes(3)
     expect(logInfoMock).toBeCalledWith(
       { result: { status: 200 } },
       'Success: New order record sent to registered webhook webhook.com/1.'