fix: deduplicate order notifications #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables timestamps from the
dynamodb-toolboxORM, which were causing nop modifications to entities to cause a MODIFY event in the DynamoDB Event Stream, and triggering the Order Notifications Lambda multiple times per order created.Docs: https://www.dynamodbtoolbox.com/docs#conventions-and-motivations:~:text=Created%20and%20modified%20timestamps%20are%20enabled%20by%20default.
Testing
To reproduce the error, stand up the server and send an order in. Observe in the logs that the Order Notifications Lambda is triggered multiple times, and that the difference in the record for each trigger is only the
_md(modified timestamp) of the record.Tested manually, and verified that order creation now only triggers the Order Notifications Lambda one time.