add suggestions

Uniswap · Mar 27, 2024 · 06bb849 · 06bb849
2 parents 86a167b + e4d9d90
commit 06bb849
Show file tree

Hide file tree

Showing 22 changed files with 26 additions and 25 deletions.
diff --git a/.forge-snapshots/DynamicFees.swap_updateDynamicFeeInBeforeSwap.snap b/.forge-snapshots/DynamicFees.swap_updateDynamicFeeInBeforeSwap.snap
@@ -1 +1 @@
-140965
+141181
diff --git a/.forge-snapshots/DynamicFees.swap_withDynamicFee.snap b/.forge-snapshots/DynamicFees.swap_withDynamicFee.snap
@@ -1 +1 @@
-89960
+90176
diff --git a/.forge-snapshots/PoolManager.addLiquidity.snap b/.forge-snapshots/PoolManager.addLiquidity.snap
@@ -1 +1 @@
-145779
+145959
diff --git a/.forge-snapshots/PoolManager.addLiquidity_withEmptyHook.snap b/.forge-snapshots/PoolManager.addLiquidity_withEmptyHook.snap
@@ -1 +1 @@
-265619
+265799
diff --git a/.forge-snapshots/PoolManager.addLiquidity_withNative.snap b/.forge-snapshots/PoolManager.addLiquidity_withNative.snap
@@ -1 +1 @@
-140462
+140642
diff --git a/.forge-snapshots/PoolManager.bytecodeSize.snap b/.forge-snapshots/PoolManager.bytecodeSize.snap
@@ -1 +1 @@
-22999
+23026
diff --git a/.forge-snapshots/PoolManager.donate_gasWith1Token.snap b/.forge-snapshots/PoolManager.donate_gasWith1Token.snap
@@ -1 +1 @@
-101510
+101654
diff --git a/.forge-snapshots/PoolManager.donate_gasWith2Tokens.snap b/.forge-snapshots/PoolManager.donate_gasWith2Tokens.snap
@@ -1 +1 @@
-128451
+128667
diff --git a/.forge-snapshots/PoolManager.removeLiquidity.snap b/.forge-snapshots/PoolManager.removeLiquidity.snap
@@ -1 +1 @@
-150044
+150224
diff --git a/.forge-snapshots/PoolManager.removeLiquidity_withEmptyHook.snap b/.forge-snapshots/PoolManager.removeLiquidity_withEmptyHook.snap
@@ -1 +1 @@
-56394
+56574
diff --git a/.forge-snapshots/PoolManager.removeLiquidity_withNative.snap b/.forge-snapshots/PoolManager.removeLiquidity_withNative.snap
@@ -1 +1 @@
-148580
+148760
diff --git a/.forge-snapshots/PoolManager.swap_againstLiquidity.snap b/.forge-snapshots/PoolManager.swap_againstLiquidity.snap
@@ -1 +1 @@
-60658
+60874
diff --git a/.forge-snapshots/PoolManager.swap_againstLiquidityWithNativeToken.snap b/.forge-snapshots/PoolManager.swap_againstLiquidityWithNativeToken.snap
@@ -1 +1 @@
-72652
+72868
diff --git a/.forge-snapshots/PoolManager.swap_burn6909ForInput.snap b/.forge-snapshots/PoolManager.swap_burn6909ForInput.snap
@@ -1 +1 @@
-80772
+80988
diff --git a/.forge-snapshots/PoolManager.swap_burnNative6909ForInput.snap b/.forge-snapshots/PoolManager.swap_burnNative6909ForInput.snap
@@ -1 +1 @@
-76727
+76943
diff --git a/.forge-snapshots/PoolManager.swap_mintNativeOutputAs6909.snap b/.forge-snapshots/PoolManager.swap_mintNativeOutputAs6909.snap
@@ -1 +1 @@
-139052
+139268
diff --git a/.forge-snapshots/PoolManager.swap_mintOutputAs6909.snap b/.forge-snapshots/PoolManager.swap_mintOutputAs6909.snap
@@ -1 +1 @@
-155861
+156077
diff --git a/.forge-snapshots/PoolManager.swap_simple.snap b/.forge-snapshots/PoolManager.swap_simple.snap
@@ -1 +1 @@
-147069
+147285
diff --git a/.forge-snapshots/PoolManager.swap_simpleWithNative.snap b/.forge-snapshots/PoolManager.swap_simpleWithNative.snap
@@ -1 +1 @@
-133193
+133409
diff --git a/.forge-snapshots/PoolManager.swap_withHooks.snap b/.forge-snapshots/PoolManager.swap_withHooks.snap
@@ -1 +1 @@
-60633
+60849
diff --git a/src/PoolManager.sol b/src/PoolManager.sol
@@ -31,6 +31,7 @@ contract PoolManager is IPoolManager, ProtocolFees, NoDelegateCall, ERC6909Claim
     using Hooks for IHooks;
     using Position for mapping(bytes32 => Position.Info);
     using CurrencyLibrary for Currency;
+    using CurrencyDelta for Currency;
     using SwapFeeLibrary for uint24;
     using PoolGetters for Pool.State;
 
@@ -85,7 +86,7 @@ contract PoolManager is IPoolManager, ProtocolFees, NoDelegateCall, ERC6909Claim
 
     /// @inheritdoc IPoolManager
     function currencyDelta(address caller, Currency currency) external view returns (int256) {
-        return CurrencyDelta.get(caller, currency);
+        return currency.getDelta(caller);
     }
 
     /// @inheritdoc IPoolManager
@@ -142,7 +143,7 @@ contract PoolManager is IPoolManager, ProtocolFees, NoDelegateCall, ERC6909Claim
     function _accountDelta(Currency currency, int128 delta) internal {
         if (delta == 0) return;
 
-        int256 current = CurrencyDelta.get(msg.sender, currency);
+        int256 current = currency.getDelta(msg.sender);
         int256 next = current + delta;
 
         unchecked {
@@ -153,7 +154,7 @@ contract PoolManager is IPoolManager, ProtocolFees, NoDelegateCall, ERC6909Claim
             }
         }
 
-        CurrencyDelta.set(msg.sender, currency, next);
+        currency.setDelta(msg.sender, next);
     }
 
     /// @dev Accumulates a balance change to a map of currency to balance changes

diff --git a/src/libraries/CurrencyDelta.sol b/src/libraries/CurrencyDelta.sol
@@ -21,15 +21,15 @@ library CurrencyDelta {
         }
     }
 
-    function set(address caller, Currency currency, int256 delta) internal {
+    function setDelta(Currency currency, address caller, int256 delta) internal {
         bytes32 hashSlot = _computeSlot(caller, currency);
 
         assembly {
             tstore(hashSlot, delta)
         }
     }
 
-    function get(address caller, Currency currency) internal view returns (int256 delta) {
+    function getDelta(Currency currency, address caller) internal view returns (int256 delta) {
         bytes32 hashSlot = _computeSlot(caller, currency);
 
         assembly {