Move initialize event (#909)

Uniswap · Oct 21, 2024 · 4aa6c3d · 4aa6c3d
1 parent d9403bd
commit 4aa6c3d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.forge-snapshots/initialize.snap b/.forge-snapshots/initialize.snap
@@ -1 +1 @@
-51533
+51532
diff --git a/.forge-snapshots/poolManager bytecode size.snap b/.forge-snapshots/poolManager bytecode size.snap
@@ -1 +1 @@
-23659
+23694
diff --git a/src/PoolManager.sol b/src/PoolManager.sol
@@ -131,11 +131,12 @@ contract PoolManager is IPoolManager, ProtocolFees, NoDelegateCall, ERC6909Claim
 
         tick = _pools[id].initialize(sqrtPriceX96, lpFee);
 
-        key.hooks.afterInitialize(key, sqrtPriceX96, tick);
-
+        // event is emitted before the afterInitialize call to ensure events are always emitted in order
         // emit all details of a pool key. poolkeys are not saved in storage and must always be provided by the caller
         // the key's fee may be a static fee or a sentinel to denote a dynamic fee.
         emit Initialize(id, key.currency0, key.currency1, key.fee, key.tickSpacing, key.hooks, sqrtPriceX96, tick);
+
+        key.hooks.afterInitialize(key, sqrtPriceX96, tick);
     }
 
     /// @inheritdoc IPoolManager