chore: remove unnecessary line #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Oct 30, 2024
| @@ -80,7 +80,6 @@ contract PoolManager is IPoolManager, ProtocolFees, NoDelegateCall, ERC6909Claim | |||
| using SafeCast for *; | |||
| using Pool for *; | |||
| using Hooks for IHooks; | |||
| using Position for mapping(bytes32 => Position.State); | |||
There was a problem hiding this comment.
i think youre right. Can you also remove it in the ProxyPoolManager.sol
|
Sorry for the delay here! We've now added a snapshot to check bytecode hash in #924, so if CI passes here we know that you dont alter the bytecode and we can merge :) |
|
thanks @hensha256 |
hensha256
approved these changes
Dec 12, 2024
|
im so sorry, you didnt sign your commits so we cannot merge the PR in the current state 🥲 |
|
@hensha256 should be good now :) |
hensha256
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
remove unnecessary line, pass tests, no functions from
Positionlibrary are used.