Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cuda not being used on windows: update pytorch version #6064

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix cuda not being used on windows: update pytorch version #6064

merged 1 commit into from
Mar 6, 2024

Conversation

alex-mccarthy-unity
Copy link
Collaborator

@alex-mccarthy-unity alex-mccarthy-unity commented Mar 4, 2024

Proposed change(s)

These references were missed when upgrading from pytorch 1.x to 2.x in #6013

References found by running grep -R '1\.13\.1' .

Install command chosen from the guide at https://pytorch.org/get-started/locally/

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Probably related to #6055 : the user screenshot shows they're running the CPU-only version of cuda on a windows machine.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

These references were missed when upgrading from pytorch 1.x to 2.x in #6013

References found by running `grep -R '1\.13\.1' .`

Install command chosen from the guide at https://pytorch.org/get-started/locally/
Copy link
Collaborator

@miguelalonsojr miguelalonsojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alex-mccarthy-unity alex-mccarthy-unity merged commit 1bee58f into Unity-Technologies:develop Mar 6, 2024
4 checks passed
@alex-mccarthy-unity alex-mccarthy-unity deleted the fix-pytorch-version-skew branch March 6, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants