Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPU continuous build: correct torch version, and remove torchaudio and torchvideo #6074

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

alex-mccarthy-unity
Copy link
Collaborator

@alex-mccarthy-unity alex-mccarthy-unity commented Mar 6, 2024

Proposed change(s)

Remove torchaudio and torchvideo, which are unused (which fixes trying to download the wrong torchaudio version)

Use a slightly older cuda version, since that makes cuda detection work on the machines we're running on (RTX 2080's on Ubuntu 18.04, which presumably aren't compatible with CUDA 12).

Passing GPU run with this change: https://unity-ci.cds.internal.unity3d.com/job/34891013/logs

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

torchaudio 0.17 doesn't exist, but 2.2 does.

Use a slightly older cuda version, since that makes cuda detection work on the machines we're running on (RTX 2080's on Ubuntu 18.04, which presumably aren't compatible with CUDA 12).

(I'm not sure if the tests actually need torchaudio or torchvision, since those aren't listed dependencies of any of our software, but let's at least install a valid one)

Passing yamato run with this change: https://unity-ci.cds.internal.unity3d.com/job/34869354/logs
@alex-mccarthy-unity alex-mccarthy-unity changed the title Fix GPU continuous build: correct torchaudio version Fix GPU continuous build: correct torch version, and remove torchaudio and torchvideo Mar 7, 2024
Copy link
Collaborator

@miguelalonsojr miguelalonsojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT.

@miguelalonsojr miguelalonsojr merged commit 92cbaad into develop Mar 9, 2024
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the local-fix-gpu-tests branch March 9, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants