Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subdivision scheme and normal interpolation on export #196

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix subdivision scheme and normal interpolation on export #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions package/com.unity.formats.usd/Runtime/Scripts/IO/Geometry/MeshExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,16 +295,27 @@ static void ExportMesh(ObjectContext objContext,
scene.Write(path, sample);
UnityEngine.Profiling.Profiler.EndSample();

pxr.UsdPrim usdPrim = scene.GetPrimAtPath(path);

// TODO: this is a bit of a half-measure, we need real support for primvar interpolation.
// Set interpolation based on color count.
if (sample.colors != null && sample.colors.Length == 1) {
pxr.UsdPrim usdPrim = scene.GetPrimAtPath(path);
var colorPrimvar = new pxr.UsdGeomPrimvar(usdPrim.GetAttribute(pxr.UsdGeomTokens.primvarsDisplayColor));
colorPrimvar.SetInterpolation(pxr.UsdGeomTokens.constant);
var opacityPrimvar = new pxr.UsdGeomPrimvar(usdPrim.GetAttribute(pxr.UsdGeomTokens.primvarsDisplayOpacity));
opacityPrimvar.SetInterpolation(pxr.UsdGeomTokens.constant);
}

// for polygonal meshes, we do not want the default subdivision scheme of "catmull-clark" but instead "none"
// so that authored normals keep working.
var usdGeomMesh = new pxr.UsdGeomMesh(usdPrim);
usdGeomMesh.CreateSubdivisionSchemeAttr().Set(new pxr.TfToken("none"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably make this part of the schema class, in USD.NET.Unity.


// explicitly set the normal interpolation here –
// default should be "vertex" anyways but seems some viewers don't respect the default
Copy link
Contributor

@jcowles jcowles Jul 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you note the problematic viewers and versions here, for future reference?

var normalInterp = new pxr.UsdGeomPrimvar(usdPrim.GetAttribute(pxr.UsdGeomTokens.normals));
normalInterp.SetInterpolation(pxr.UsdGeomTokens.vertex);

string usdMaterialPath;
if (exportContext.exportMaterials && sharedMaterial != null) {
if (!exportContext.matMap.TryGetValue(sharedMaterial, out usdMaterialPath)) {
Expand All @@ -329,9 +340,6 @@ static void ExportMesh(ObjectContext objContext,
}
}

var usdPrim = scene.GetPrimAtPath(path);
var usdGeomMesh = new pxr.UsdGeomMesh(usdPrim);

// Process each subMesh and create a UsdGeomSubset of faces this subMesh targets.
for (int si = 0; si < mesh.subMeshCount; si++) {
int[] indices = mesh.GetTriangles(si);
Expand Down