Giving force mode parameters as arguments when calling startForceMode #208
+422
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URJala
force-pushed
the
force_mode_arguments
branch
2 times, most recently
from
39e858b
to
d7f1fc3
Compare
And in client library
URJala
force-pushed
the
force_mode_arguments
branch
from
bd4ddd9
to
535b083
Compare
fmauch
reviewed
Sep 4, 2024
Formatting Co-authored-by: Felix Exner (fexner) <[email protected]>
Formatting Co-authored-by: Felix Exner (fexner) <[email protected]>
fmauch
reviewed
Oct 7, 2024
Co-authored-by: Felix Exner (fexner) <[email protected]>
fmauch
approved these changes
Oct 8, 2024
fmauch
requested changes
Oct 8, 2024
Added them to the various checks for starting force mode. I created IncompatibleRobotVersion instead of using VersionMismatch, as the VersionMismatch would not give enough information in my opinion.
URJala
force-pushed
the
force_mode_arguments
branch
from
322eb05
to
179dd05
Compare
urfeex
requested changes
Nov 5, 2024
Co-authored-by: Felix Exner <[email protected]>
After further thought, I dont think the Incompatible version exception is appropriate for one of the exception calls, as the robot is not actually incompatible, the function just needs more information. The new exception conveys that, i think. I can't quite make my mind up about whether it should mention that this is due to the robot version, though, so I have left it out for now.
fmauch
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.