set receive timeout after connecting the client #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you are right. Thanks for spotting this and providing the fix as a PR! |
fmauch
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
LGTM. Since we set the timeout in the connect() method this has to be done afterwards.
|
Before merging I'd like to test this on a real hardware. I might have never switched installations using the dashboard client before. If a higher timeout is needed in order to switch installations, we should probably also change the default value. |
|
This PR hasn't made any progress for quite some time and will be closed soon. Please comment if it is still relevant. |
|
Yes, this is still relevant. I should test and merge this! |
|
I finally got around testing this on real hardware. Thank you @steffen-roperobotics for providing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dashboard client connect function resets the receive timeout to 1 s. To avoid that the receive timeout is reset the setReceiveTimeout call is moved to after the client is connected.