Skip to content

Commit

Permalink
Return isThesisSupervisor when fetching program-managements
Browse files Browse the repository at this point in the history
  • Loading branch information
AleksTeresh committed Oct 9, 2024
1 parent 79088f5 commit 0d28fc5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions src/server/routes/programManagement.integration-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,15 @@ describe('program-managements router', () => {
{
id: programManagement1.id,
programId: programManagement1.programId,
isThesisApprover: programManagement1.isThesisApprover,
userId: programManagement1.userId,
user: expect.any(Object),
program: expect.any(Object),
},
{
id: programManagement2.id,
programId: programManagement2.programId,
isThesisApprover: programManagement2.isThesisApprover,
userId: programManagement2.userId,
user: expect.any(Object),
program: expect.any(Object),
Expand Down Expand Up @@ -246,13 +248,15 @@ describe('program-managements router', () => {
id: programThatTheUserCanManage.id,
programId: programThatTheUserCanManage.programId,
userId: programThatTheUserCanManage.userId,
isThesisApprover: programThatTheUserCanManage.isThesisApprover,
user: expect.any(Object),
program: expect.any(Object),
},
{
id: programManagement2.id,
programId: programManagement2.programId,
userId: programManagement2.userId,
isThesisApprover: programManagement2.isThesisApprover,
user: expect.any(Object),
program: expect.any(Object),
},
Expand Down
2 changes: 1 addition & 1 deletion src/server/routes/programManagement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ programManagementRouter.get(
async (req: RequestWithUser, res: Response) => {
const { isAdmin } = req.user
const programs = await ProgramManagement.findAll({
attributes: ['id', 'programId', 'userId'],
attributes: ['id', 'programId', 'userId', 'isThesisApprover'],
where: isAdmin
? {}
: {
Expand Down
1 change: 1 addition & 0 deletions src/server/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ export interface ServerThesesFiltersPutRequest extends Request {
export interface ProgramManagementData {
userId: string
programId: string
isThesisApprover: boolean
program?: ProgramData
user?: User
id?: string
Expand Down

0 comments on commit 0d28fc5

Please sign in to comment.