fix: course unit filtering logic

UniversityOfHelsinkiCS · Apr 23, 2024 · 9b8d3b5 · 9b8d3b5
1 parent bd9a831
commit 9b8d3b5
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/updater/updateCoursesAndTeacherFeedbackTargets/updateCoursesAndTeacherFeedbackTargets.js b/src/updater/updateCoursesAndTeacherFeedbackTargets/updateCoursesAndTeacherFeedbackTargets.js
@@ -403,7 +403,10 @@ const getArchivedCoursesToDelete = async (courses) => {
 
 const coursesHandler = async (courses) => {
   // Filter out old AY courses. Already existing ones remain in db.
-  const courseUnits = [].concat(...courses.map((course) => course.courseUnits)).filter(({ code }) => code.startsWith('AY') && !code.match('^AY[0-9]+$'))
+  const courseUnits = courses
+    .flatMap((course) => course.courseUnits)
+    .filter(({ code }) => !(code.startsWith('AY') && !code.match('^AY[0-9]+$')))
+
   await createCourseUnits(courseUnits)
 
   const includeCurs = await getIncludeCurs()