Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle edge cases #8719

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Nov 12, 2024

Handle a couple edge cases related to project lifecycle metrics:

  1. If the average time spent was less than a day, we'd show "0 days". Now we show "less than a day" instead.
  2. If the number of flags grows very large, it'd start pushing out the lifecycle icon. Instead, we now format in nicely.

Before:
image
image

After:
image
image

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 11:06am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 11:06am

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@thomasheartman thomasheartman changed the title [wip] chore: handle edge cases chore: handle edge cases Nov 12, 2024
@thomasheartman thomasheartman merged commit 42198ce into main Nov 12, 2024
11 checks passed
@thomasheartman thomasheartman deleted the 1-3096/project-status-layout-fixes branch November 12, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants