feat: edit release plan template #8723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
nunogois
reviewed
Nov 12, 2024
frontend/src/hooks/api/getters/useReleasePlanTemplates/useReleasePlanTemplateInstance.ts
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Nov 12, 2024
nunogois
reviewed
Nov 12, 2024
| <FormTemplate | ||
| title={`Edit template ${template.name}`} | ||
| description='Edit a release plan template that makes it easier for you and your team to release features.' | ||
| > |
There was a problem hiding this comment.
I assume we'll add other props like formatApiCode at a later stage?
There was a problem hiding this comment.
Yeah, we have to look at extending this to fit other type of information as well
nunogois
reviewed
Nov 12, 2024
frontend/src/component/releases/ReleasePlanTemplate/EditReleasePlanTemplate.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Nov 12, 2024
frontend/src/component/releases/ReleasePlanTemplate/EditReleasePlanTemplate.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Nov 12, 2024
frontend/src/component/releases/ReleasePlanTemplate/EditReleasePlanTemplate.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Nov 12, 2024
frontend/src/component/releases/ReleasePlanTemplate/EditReleasePlanTemplate.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Nov 12, 2024
frontend/src/component/releases/ReleasePlanTemplate/EditReleasePlanTemplate.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Nov 12, 2024
frontend/src/component/releases/ReleaseManagement/ReleasePlanTemplateCardMenu.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Nov 12, 2024
| <ReleasePlanTemplateCardMenu | ||
| template={template} | ||
| clickHandler={clickHandler} | ||
| /> |
There was a problem hiding this comment.
This one confuses me a bit. If we always want to navigate on click, why not wrap the card in a link instead?
There was a problem hiding this comment.
The card is already wrapped in a click, but I have to override that for the menu, and thus also specify an onclick for the menu items
nunogois
approved these changes
Nov 12, 2024
…ePlanTemplate.tsx Co-authored-by: Nuno Góis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This facilitates editing a release plan template
In order to split large UI projects up, this only allows you to change the name and description (but will show you the names of milestones in the UI), and will carry the existing milestones with it when making a request. We'll tackle editing milestones and their strategies in a different PR