Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FedRAMP docs #8815
FedRAMP docs #8815
Changes from 8 commits
00d79f6
d0db527
6ee384b
e91088d
5166c3b
9421ff4
cdf57cc
a90dd04
ab0130f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would service accounts as well as personal access tokens be based on PKI as well @dsusa72 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, but I don't think it's relevant because we're not going to list here all the points in the solution where we use encryption. When we implement my suggestion in cell G15 (Encryption overview diagram), we will get down to this detail level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section isn't about encryption, but rather PKI, e.g. certificates. Saying that we use certificates only on AWS and Google, if we in fact use certificate-based auth on our API seems like an omission. Unless of course we don't use certs on those services. Could an engineer validate this quickly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelferranti , This was already validated with a principal eng. For clarification: we're not saying we use certificates "on" AWS & Google. We're saying "issued by" them, which is different. We're saying these are the only two CAs (Certification Authorities) that we get certificates from, as opposed to using certs from a Gov authority or self-signed ones. In the NIST control wording these two CAs sohuld be considered "approved service providers".
I.e. this is about the type of certs se use and not "where" we use them. If we attempt to describe "where", I still recommend my suggestion on cell G15.