chore: release plans flow in flag environments #8843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
daveleek
reviewed
Nov 25, 2024
| <ReleasePlanMilestone | ||
| milestone={milestone} | ||
| status={ | ||
| index === activeIndex |
There was a problem hiding this comment.
Don't we have activeMilestoneId we could use here?
daveleek
reviewed
Nov 25, 2024
| {releasePlans.map((plan) => ( | ||
| <ReleasePlan key={plan.id} plan={plan} /> | ||
| ))} | ||
| <ConditionallyRender |
There was a problem hiding this comment.
Aren't we moving away from these? Is it being used here for consistency with the rest of the file?
There was a problem hiding this comment.
Are we? I'm not 100% sure. But like you said this is at least consistent with the rest of the code in the file, so we can return to this later.
daveleek
reviewed
Nov 25, 2024
| </SectionSeparator> | ||
| } | ||
| /> | ||
| <ConditionallyRender |
There was a problem hiding this comment.
Same question around these being moved away from and consistency as further down
daveleek
approved these changes
Nov 25, 2024
chriswk
approved these changes
Nov 25, 2024
nunogois
force-pushed
the
chore-release-plans-shown-in-flag-envs
branch
from
f42b788 to
38a0b0a
Compare
nunogois
force-pushed
the
chore-release-plans-shown-in-flag-envs
branch
from
93b2d2b to
068c829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2816/add-release-plan-to-feature-flag-from-release-template
https://linear.app/unleash/issue/2-2818/list-release-plan-with-milestones-in-feature-flag-environment-section
https://linear.app/unleash/issue/2-2819/removing-release-plan-from-feature
Implements the release plan flow in the feature flag environment.
You can now manage release plans in a feature flag environment by adding or removing them, as well as start milestones.
release_plans.mp4