fix(1-3173): clear "removed tags" when you bulk update tags #8952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
thomasheartman
changed the title
Tymek
reviewed
Dec 11, 2024
Comment on lines
115
to
118
| const submitAndClear = () => { | ||
| onSubmit(payload); | ||
| dispatch({ type: 'reset' }); | ||
| }; |
There was a problem hiding this comment.
maybe submitAndReset? Clear is related to removing also "initialValues" because of reason === 'clear' on an Autocomplete
There was a problem hiding this comment.
Yes, good point. I agree with this. But do you have a different word for clear, because having both is really confusing me. Maybe "resetToInitialValues" or something?
Tymek
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug wherein the list of tags to remove from a group of tags wouldn't be correctly updated.
Repro steps
frontend/src/component/feature/FeatureView/FeatureOverview/ManageTagsDialog/ManageBulkTagsDialog.tsx'sManagebulkTagsDialog. Log the value of thepayloadvariable.Discussion points
This gives us both a
clearand aresetevent, which is unfortunate because they sound like they do the same thing. I'd suggest renaming theclearevent (because it doesn't really clear the state completely), but I'm not sure to what. Happy to do that if you have a suggestion.I have not tested that submission of the form actually resets the state. I spent about 45 minutes looking at it, but couldn't find a way that was sensible and worked (considered spying: couldn't make it work; considered refactoring and extracting components: think that's too much of a change). I think this is benign enough that it can go without a test for that thing actually being called.
I did, however, test the different reducer commands.