fix: check for enterprise in the create/edit templates UI #8985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
|
@gastonfournier thanks, yeah updated description now |
gastonfournier
requested changes
Dec 16, 2024
gastonfournier
approved these changes
Dec 16, 2024
| @@ -32,7 +40,7 @@ export const ReleaseManagement = () => { | |||
| }} | |||
| maxWidth='700px' | |||
| permission={CREATE_RELEASE_TEMPLATE} | |||
| disabled={false} | |||
| disabled={!isEnterprise()} | |||
Comment on lines
+23
to
+25
| if (!releasePlansEnabled) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
I think this is fine if the feature is disabled you should not be able to see this... I don't think it's needed due to
unleash/frontend/src/component/menu/routes.ts
Lines 290 to 292 in 3696420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiding with enterprise tag in routes wasn't enough anymore as we're showing those to Pro with upgrade messages. This temporarily disables the UI completely.
Before
After
Also disables the create screen if you know the direct url:
