fix: delta do not return archived as changed #9062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@sjaanus, core features have been modified in this pull request. Please review carefully! |
github-actions
bot
requested review from
chriswk,
FredrikOseberg,
gastonfournier and
ivarconr
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
sjaanus
commented
Jan 6, 2025
| (feature) => | ||
| projects.includes('*') || projects.includes(feature.project), | ||
| ) | ||
| .map((feature) => feature.name); |
There was a problem hiding this comment.
This was an actual big bug. We were returning the removed as complex object, but to API it should go as string array.
sjaanus
commented
Jan 6, 2025
| @@ -197,6 +200,9 @@ export class ClientFeatureToggleDelta { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
We needed a way to clear out delta between e2e test runs. We might find a better way in future.
sjaanus
commented
Jan 6, 2025
| @@ -217,6 +223,7 @@ export class ClientFeatureToggleDelta { | |||
| ...new Set( | |||
| changeEvents | |||
| .filter((event) => event.featureName) | |||
| .filter((event) => event.type !== 'feature-archived') | |||
There was a problem hiding this comment.
Change events should not have archived events. These belong to removed.
sjaanus
commented
Jan 6, 2025
| import { validateSchema } from '../validate'; | ||
| import type { ClientFeaturesDeltaSchema } from './client-features-delta-schema'; | ||
|
|
||
| test('clientFeaturesDeltaSchema all fields', () => { |
sjaanus
commented
Jan 6, 2025
| @@ -44,7 +42,7 @@ export class ClientFeatureToggleService { | |||
| async getClientDelta( | |||
| revisionId: number | undefined, | |||
| query: IFeatureToggleQuery, | |||
| ): Promise<RevisionDeltaEntry | undefined> { | |||
| ): Promise<ClientFeaturesDeltaSchema | undefined> { | |||
There was a problem hiding this comment.
Fix the types. RevisionDeltaEntry has removed as complex objects, but we are returning string array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our delta API was returning archived feature as updated. Now making sure we do not put
archived-featureevent intoupdatedevent array.Also stop returning removed as complex object.