Minor change to menu, and links to documentation #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh5
requested changes
Nov 22, 2021
| <!--START PRIVACY POLICY--> | ||
| <q-item | ||
| clickable | ||
| @click="showPrivacyPolicyDialog" | ||
| v-ripple> | ||
| <q-item-section avatar> | ||
| <q-icon name="subject"/> | ||
| <q-icon name="shield-account"/> |
There was a problem hiding this comment.
What icon is this? Doesn't reference anything that I can tell
| @@ -17,7 +17,9 @@ | |||
| > | |||
|
|
|||
| <!--START LIBRARY PATHS--> | |||
| <h5 class="q-mb-none">{{ $t('components.settings.library.pathConfiguration') }}</h5> | |||
| <h5 class="q-mb-none">{{ $t('components.settings.library.pathConfiguration') }} | |||
| <a href="https://docs.unmanic.app/docs/configuration/library_settings#library-path-configuration"><i class="on-right material-icons q-icon">help</i></a> | |||
There was a problem hiding this comment.
I do not want direct links to external documentation. If I break the urls, then that wrecks these links.
I would rather attempt to bring in the documentation text into theses sorts of help messages.
I have create an issue describing what I mean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I unified the bottom part of the main menu and the settings menu so they both have a link to the Help & Documentation page and a link to the privacy policy.
I also added inline icons at the end of several headers in the settings area that link to the online documentation site to make it easier for people to get help without opening issues.