Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ffmpeg helper as submodule for extract_srt_subtitles_to_files #376

Closed
wants to merge 2 commits into from

Conversation

bambanah
Copy link

@bambanah bambanah commented Jan 4, 2024

Update to include this PR:

Since extracting srt files doesn't include a frame value in the ffmpeg progress messages, we need to use the time value instead

Note: This will need to stay in a draft state until the PR is merged, and this PR will then need to be updated to point to the latest commit number

@Josh5
Copy link
Contributor

Josh5 commented Feb 29, 2024

@bambanah I've created a new project here for use to continue developing this plugin. Are you able to re-open this PR against it:
https://github.com/Unmanic/plugin.extract_srt_subtitles_to_files

@bambanah
Copy link
Author

bambanah commented May 6, 2024

@Josh5 No worries! Just waiting on this PR to be merged so that this plugin can display progress. Will open PR against the new plugin repo after that

@bambanah bambanah closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants