Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Update for Cohort 4 #52

Merged
merged 9 commits into from
Oct 15, 2024
Merged

Content Update for Cohort 4 #52

merged 9 commits into from
Oct 15, 2024

Conversation

pvl19
Copy link
Collaborator

@pvl19 pvl19 commented Oct 10, 2024

  • Incorporated feedback into Day 1 slides
  • Added requirements for final project and guidelines for module 1 milestones into Day 1 slides
  • Updated README.md with updated requirements and guidelines
  • Updated team_project_1.md with updated requirements and guidelines
  • Moved some content between README.md and team_project_1.md to (hopefully) improve organization and flow of those pages

Copy link

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

Copy link

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

Copy link
Member

@danielrazavi danielrazavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more Additional Note aside the comments that are present across the files:

  • The Slides folder is a mess. There is a folder that is called Team Project 1 and Team Project 2, and there are also additional slides. Feel free to remove the folders and stick with the new slides you have proposed.

team_project_1.md Outdated Show resolved Hide resolved
team_project_1.md Outdated Show resolved Hide resolved
team_project_1.md Outdated Show resolved Hide resolved
team_project_1.md Outdated Show resolved Hide resolved
team_project_1.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

Copy link

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@danielrazavi
Copy link
Member

@pvl19 @moejennie can you please review?

Copy link

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@pvl19
Copy link
Collaborator Author

pvl19 commented Oct 15, 2024

Thanks for those updates, looks good to me! I also removed the previous example datasets from the slides.

@danielrazavi
Copy link
Member

Great! Marging in. :)

@danielrazavi danielrazavi merged commit b968796 into main Oct 15, 2024
1 check passed
@danielrazavi danielrazavi deleted the c4_updates branch October 15, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants