-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved download page #41
base: master
Are you sure you want to change the base?
Conversation
index.html
Outdated
font-size: 30px; | ||
} | ||
|
||
.linebrBefore:before { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this class? Could this be solved using padding or margin instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should have been solved that way. I have corrected it to use margin instead now.
Aside from the code style and code problems, the UI is a bit confusing. Re-using the upload dialog is confusing as previously that sort of UI is a drop zone for files and now it is a download button so it seems weird as a pure button. But aside from that small confusion the UI itself looks bad because the large box is not centered vertically and its hard for the eye to find a space. It would be better with a smaller download button and if you really want a box putting a border around the whole thing. |
Improved the download page like it is suggested here