Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests to skip on CRAN #103

Merged
merged 3 commits into from
Sep 29, 2022
Merged

update tests to skip on CRAN #103

merged 3 commits into from
Sep 29, 2022

Conversation

erika-tyagi
Copy link
Member

Adds testthat::skip_on_cran() in response to the following email from CRAN:

It seems we need to remind you of the CRAN policy:

'Packages which use Internet resources should fail gracefully with an informative message if the resource is not available or has changed (and not give a check warning nor error).'

This needs correction whether or not the resource recovers.

And the following guidance from rOpenSci (here):

Your tests should ideally run without needing an actual internet connection nor the API being up. Your tests that do need to interact with the API should be skipped on CRAN. testthat::skip_on_cran() will ensure that.

Bumps up the version number and rebuilds the package for CRAN resubmission accordingly. Also adds additional test environments.

@erika-tyagi erika-tyagi merged commit f6b86f1 into main Sep 29, 2022
@erika-tyagi erika-tyagi deleted the cran-error branch February 6, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant