-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filled in missing EU addresses #212
Filled in missing EU addresses #212
Conversation
b057639
to
98c6691
Compare
Yeah this is undesirable. It's not foolproof enough that I wouldn't want it to be automated.
Can you file a bug? |
|
98c6691
to
5cc027f
Compare
Removed. |
5cc027f
to
12a196d
Compare
With EU support in the decomp (pret/pmd-sky#36), it is now possible to precisely identify the address of any NA/EU symbol when given an address in the other game version. I updated the syncing script within the decomp project to fill in any missing addresses between EU/NA (mostly EU). There were a handful of cases where EU and NA were pointing to different symbols, which I also ironed out.
For data lengths, I simply copied over the NA length to the EU length. It is not feasible to determine the length of a symbol automatically with just the ASM, and there are too many to inspect all of them manually. If the assumption of equal NA/EU lengths is undesirable, I can remove all of the newly added length entries instead.
I noticed that
GUMMI_IQ_STRING_IDS
andGUMMI_LIKE_STRING_IDS
in overlay 29 are set to the same address. The data at this address has a size of 8, which leans towardsGUMMI_LIKE_STRING_IDS
being the correct entry. I'm not familiar enough with message IDs to quickly find the correctGUMMI_IQ_STRING_IDS
, so I left both of them as duplicates for now when adding the EU address.