Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filled in missing EU addresses #212

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

AnonymousRandomPerson
Copy link
Contributor

@AnonymousRandomPerson AnonymousRandomPerson commented Nov 22, 2023

With EU support in the decomp (pret/pmd-sky#36), it is now possible to precisely identify the address of any NA/EU symbol when given an address in the other game version. I updated the syncing script within the decomp project to fill in any missing addresses between EU/NA (mostly EU). There were a handful of cases where EU and NA were pointing to different symbols, which I also ironed out.

For data lengths, I simply copied over the NA length to the EU length. It is not feasible to determine the length of a symbol automatically with just the ASM, and there are too many to inspect all of them manually. If the assumption of equal NA/EU lengths is undesirable, I can remove all of the newly added length entries instead.

I noticed that GUMMI_IQ_STRING_IDS and GUMMI_LIKE_STRING_IDS in overlay 29 are set to the same address. The data at this address has a size of 8, which leans towards GUMMI_LIKE_STRING_IDS being the correct entry. I'm not familiar enough with message IDs to quickly find the correct GUMMI_IQ_STRING_IDS, so I left both of them as duplicates for now when adding the EU address.

@AnonymousRandomPerson AnonymousRandomPerson force-pushed the master branch 2 times, most recently from b057639 to 98c6691 Compare November 22, 2023 05:37
@UsernameFodder
Copy link
Owner

For data lengths, I simply copied over the NA length to the EU length. It is not feasible to determine the length of a symbol automatically with just the ASM, and there are too many to inspect all of them manually. If the assumption of equal NA/EU lengths is undesirable, I can remove all of the newly added length entries instead.

Yeah this is undesirable. It's not foolproof enough that I wouldn't want it to be automated.

I noticed that GUMMI_IQ_STRING_IDS and GUMMI_LIKE_STRING_IDS in overlay 29 are set to the same address. The data at this address has a size of 8, which leans towards GUMMI_LIKE_STRING_IDS being the correct entry. I'm not familiar enough with message IDs to quickly find the correct GUMMI_IQ_STRING_IDS, so I left both of them as duplicates for now when adding the EU address.

Can you file a bug?

docs/contributing.md Outdated Show resolved Hide resolved
headers/functions/arm7.h Outdated Show resolved Hide resolved
symbols/arm9.yml Show resolved Hide resolved
symbols/arm9.yml Outdated Show resolved Hide resolved
@AnonymousRandomPerson
Copy link
Contributor Author

Can you file a bug?

#214

@AnonymousRandomPerson
Copy link
Contributor Author

Yeah this is undesirable. It's not foolproof enough that I wouldn't want it to be automated.

Removed.

symbols/arm7.yml Outdated Show resolved Hide resolved
@UsernameFodder UsernameFodder merged commit c4a1754 into UsernameFodder:master Nov 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants