Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed duplicate JP addresses #221

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Fixed duplicate JP addresses #221

merged 1 commit into from
Dec 10, 2023

Conversation

AnonymousRandomPerson
Copy link
Contributor

The following symbol addresses conflicted for JP. I inferred the fixed addresses based on the relative addresses of US/EU.

  • MIN_IQ_EXCLUSIVE_MOVE_USER and MIN_IQ_ITEM_MASTER
  • FACADE_DAMAGE_MULTIPLIER and IMPRISON_TURN_RANGE

UsernameFodder
UsernameFodder approved these changes Dec 10, 2023
View reviewed changes
Copy link
Owner

@UsernameFodder UsernameFodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually verified that both new addresses are correct.

@UsernameFodder UsernameFodder merged commit 7a1ea40 into UsernameFodder:master Dec 10, 2023
4 checks passed
@AnonymousRandomPerson AnonymousRandomPerson deleted the fix-dupe-jp branch December 10, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UsernameFodder UsernameFodder UsernameFodder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnonymousRandomPerson @UsernameFodder