Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GetSleepAnimationId with GetIdleAnimationId #251

Merged
merged 3 commits into from
Mar 24, 2024

Conversation

Frostbyte0x70
Copy link
Collaborator

Better documents GetSleepAnimationId, which is actually used to get the animation a monster should play while idling. The function has been renamed to GetIdleAnimationId.

Also documents ChangeMonsterAnimation.

Copy link
Owner

@UsernameFodder UsernameFodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, will wait a day before merging since there's a symbol name being removed.

@UsernameFodder
Copy link
Owner

Oh well I guess an alias is okay too. I figured you didn't want to add one since it's not exactly correct, but I don't mind either way.

@Frostbyte0x70
Copy link
Collaborator Author

I just added the old name as an alias (I forgot the alias system is a thing now), although I don't know if it would be better to remove it, since the old name is incorrect.

@UsernameFodder
Copy link
Owner

I just added the old name as an alias (I forgot the alias system is a thing now), although I don't know if it would be better to remove it, since the old name is incorrect.

I kind of doubt many people use this symbol? So if I had to choose I might lean towards no alias, but will defer to you.

@Frostbyte0x70
Copy link
Collaborator Author

Alright, I'll remove it then. I thought it was mandatory to add an alias since the checks were failing.

@UsernameFodder
Copy link
Owner

Alright, I'll remove it then. I thought it was mandatory to add an alias since the checks were failing.

It'll only fail for the PR the change is introduced in. So it's an ignorable error.

@UsernameFodder UsernameFodder merged commit 5744c5e into UsernameFodder:master Mar 24, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants