Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of functions used for Magic Coat #272

Merged
merged 6 commits into from
Sep 1, 2024

Conversation

assidion2
Copy link
Contributor

No description provided.

symbols/overlay29.yml Outdated Show resolved Hide resolved
@@ -8641,6 +8641,26 @@ overlay29:
Called when the in-dungeon "others" menu is open. Does not return until the menu is closed.

return: Always 0
- name: GetExclusiveItemWithEffectFromBag
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the symbol ordering? Symbols are ordered by address.

Copy link
Contributor Author

@assidion2 assidion2 Sep 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a script to automate the ordering? (Never mind, you can just locate the next defined function in Ghidra and search for that to find the position.)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there is automation. See the docs

Copy link
Owner

@UsernameFodder UsernameFodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header checks are still failing. Can you fix the formatting there as well? Like with the symbols, there's automation; see the docs.

@assidion2
Copy link
Contributor Author

assidion2 commented Sep 1, 2024

When I try to do make format I get this error: "make: *** No rule to make target `format'. Stop." I have clang-format installed, and find and xargs seem to also work. Do you know how to solve this?

(Never mind, I just had to cd into headers.)

Copy link
Owner

@UsernameFodder UsernameFodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thank you!

@UsernameFodder UsernameFodder merged commit a4d0aba into UsernameFodder:master Sep 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants