-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Couple of functions used for Magic Coat #272
Conversation
symbols/overlay29.yml
Outdated
@@ -8641,6 +8641,26 @@ overlay29: | |||
Called when the in-dungeon "others" menu is open. Does not return until the menu is closed. | |||
|
|||
return: Always 0 | |||
- name: GetExclusiveItemWithEffectFromBag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the symbol ordering? Symbols are ordered by address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a script to automate the ordering? (Never mind, you can just locate the next defined function in Ghidra and search for that to find the position.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes there is automation. See the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header checks are still failing. Can you fix the formatting there as well? Like with the symbols, there's automation; see the docs.
When I try to do make format I get this error: "make: *** No rule to make target `format'. Stop." I have clang-format installed, and find and xargs seem to also work. Do you know how to solve this? (Never mind, I just had to cd into headers.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thank you!
No description provided.