Prospectus versioning #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucuparia
requested review from
stsnel and
lwesterhof
and removed request for
stsnel
lwesterhof
requested changes
Jul 11, 2023
There was a problem hiding this comment.
Can we give the schema version to the DataSelection module and let it load the correct schema instead of duplicating the module?
Otherwise at least rename DataSelectionOld and DataSelection to DataSelectionYouth0 and DataSelectionYouth1 or something similar to make it a bit more semantic. I assume they are tied to a specific schema?
aucuparia
force-pushed
the
5199-prospectus-versioning
branch
from
39bfdb3
to
d134071
Compare
|
No duplicated module anymore. Cleaner indeed. |
aucuparia
force-pushed
the
5199-prospectus-versioning
branch
from
d134071
to
7a68f4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.