Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YDA-5720 config publication terms #341

Merged
merged 25 commits into from
Aug 6, 2024
Merged

YDA-5720 config publication terms #341

merged 25 commits into from
Aug 6, 2024

Conversation

FuHsinyu
Copy link
Member

@FuHsinyu FuHsinyu commented Aug 5, 2024 •
edited
Loading

  1. Added a endpoint set_publication_terms to retrieve new publication_terms, and store it to web server/configdirectory.
  2. Enhanced the same endpoint to retrieve terms from IRODS via a API call, in case of no terms found in/config
  3. Improved admin.index and UI to update new terms on admin page.
  4. Added an endpoint get_publication_terms for the vault.js to fetch terms.
  5. Added a preview function for terms
  6. Designed UI

@FuHsinyu
add basic ui for publication terms
a9059eb
@FuHsinyu
add endpoint to retrive local terms and add preview window for terms …
914eda2 
…in admin.html
@FuHsinyu
add reading default terms from irods, if current terms not exist in /…
e62bb72 
…config folder
@FuHsinyu
add endpoint to update terms displayed when user click publication
38f7510
@FuHsinyu
add saving terms to /config if there is no such in the /config directory
0a9f535
@FuHsinyu
add the modal for preview publication terms
ef1f03c
@FuHsinyu
let preiview function retrive current terms from endpoints instead of…
d47d2c2 
… from the text area window
@FuHsinyu
Rearrange UI components to make admin page slightly consistent in vis…
a8cdfeb 
…uals
@FuHsinyu
Move create_preview js script out of the html to a separate .js file …
7cda848 
…in the static folder
@FuHsinyu
refacorized codes
034198d
@FuHsinyu
Add type hint and doc strings
94c7668
@FuHsinyu
Remove unused codes
1aaa405
@FuHsinyu
Clean codes
a9f5492
@FuHsinyu
Formatted codes
247ea0f
@FuHsinyu
Fix the vault js to fetch terms from flask endpoint
ff15b0b
@FuHsinyu
Let the preview function preview the terms in textarea
f106c69
lwesterhof
lwesterhof requested changes Aug 6, 2024
View reviewed changes
admin/templates/admin/admin.html Outdated Show resolved Hide resolved
lwesterhof
lwesterhof requested changes Aug 6, 2024
View reviewed changes
admin/templates/admin/admin.html Outdated Show resolved Hide resolved
@FuHsinyu FuHsinyu marked this pull request as ready for review August 6, 2024 10:45
lwesterhof
lwesterhof approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@lwesterhof lwesterhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

admin/static/admin/js/create_preview.js Outdated Show resolved Hide resolved
admin/templates/admin/admin.html Outdated Show resolved Hide resolved
@lwesterhof lwesterhof merged commit f93b893 into development Aug 6, 2024
16 checks passed
@lwesterhof lwesterhof deleted the YDA-5720-config-publication-terms branch August 6, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwesterhof lwesterhof lwesterhof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FuHsinyu @lwesterhof