YDA-5952: pin JS linter versions in CI #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuHsinyu
reviewed
Sep 24, 2024
FuHsinyu
reviewed
Sep 24, 2024
FuHsinyu
reviewed
Sep 24, 2024
So that the lint job doesn't break unexpectedly after non-backwards-compatible updates to the linting software.
stsnel
force-pushed
the
yda-5952-pin-linter-version
branch
from
08c1647
to
9e4bed7
Compare
|
LGTM! A qq, if there was a break, it would happen in the git action, correct? Since i dont know how to test if this new versions will break again or not, for safety check. |
Yes, that's right. The javascript lint rule runs in Github Action, so CI wouldn't have passed if we had broken it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the lint job doesn't break unexpectedly after non-backwards-compatible updates to the linting software.