Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yda 5942 add user friendly messages csv import #522

Merged
merged 25 commits into from
Oct 1, 2024

Conversation

leonidastri
Copy link
Contributor

@leonidastri leonidastri commented Sep 12, 2024

Problem

When modifying groups with a CSV, I use groups that are already created (to add users for example) . I check the “Allow updates” button and “Process CSV”. I then get an error for existing groups even though the users have been added

Solution
When import groups using a CSV file, now the user can be informed with a simple, but useful descriptive message of the actions taken:

A message may consist of 1 or more of the following phrases:

  • Group '<group_name>' created.
  • Group '<group_name>' already exists.
  • Users added (<no_users_added>).
  • Users removed (<no_users_removed>).

This should be merge taking into account the following PR also
UtrechtUniversity/yoda-portal#362

@leonidastri leonidastri deleted the YDA-5942-add-user-friendly-messages-csv-import branch September 12, 2024 12:00
@leonidastri leonidastri restored the YDA-5942-add-user-friendly-messages-csv-import branch September 12, 2024 12:01
@leonidastri leonidastri reopened this Sep 12, 2024
@stsnel stsnel self-assigned this Sep 17, 2024
Copy link
Member

@stsnel stsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general 👍, I've added a few comments regarding some minor things

uuGroup.r Outdated Show resolved Hide resolved
util/api.py Outdated Show resolved Hide resolved
groups.py Show resolved Hide resolved
@stsnel stsnel merged commit 39a519f into development Oct 1, 2024
16 checks passed
@stsnel stsnel deleted the YDA-5942-add-user-friendly-messages-csv-import branch October 1, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants