Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yda 5951 add transformation scopus isni #524

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

leonidastri
Copy link
Contributor

The metadata schema transformation code from default-2 to default-3 currently handles ORCID-IDs and Researcher IDs, but not Scopus IDs and ISNI IDs. Because of this, metadata files with the default-2 schema containing Scopus or ISNI IDs can usually not be converted automatically to default-3.

Solution
Add a transformation function that handles transformation of an ISNI and Scopus ID that consists of a series of digits (with optional spaces) to the format that is specified in the default-3 schema

@stsnel stsnel self-requested a review September 23, 2024 15:31
Copy link
Member

@stsnel stsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general 👍 , I've added a few comments about specific parts.

schema_transformations.py Outdated Show resolved Hide resolved
schema_transformations.py Outdated Show resolved Hide resolved
schema_transformations.py Outdated Show resolved Hide resolved
schema_transformations.py Outdated Show resolved Hide resolved
@stsnel
Copy link
Member

stsnel commented Sep 26, 2024

Looks good to me 👍

@stsnel stsnel merged commit d1bb8c8 into development Sep 26, 2024
16 checks passed
@stsnel stsnel deleted the YDA-5951-add-transformation-Scopus-ISNI branch September 26, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants