fix(includes): Properly override base method on file filter (#161)

* Fix Method Override * Remove Test Code
VATSIM-UK · Aug 25, 2021 · a590844 · a590844
1 parent 22aae4a
commit a590844
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/src/Compiler/Input/Filter/ExcludeFileFilter.cs b/src/Compiler/Input/Filter/ExcludeFileFilter.cs
@@ -8,7 +8,7 @@ public ExcludeFileFilter(IEnumerable<string> fileNames) : base(fileNames)
         {
         }
 
-        public new bool Filter(string path)
+        public override bool Filter(string path)
         {
             return !base.Filter(path);
         }

diff --git a/src/Compiler/Input/Filter/IncludeFileFilter.cs b/src/Compiler/Input/Filter/IncludeFileFilter.cs
@@ -13,7 +13,7 @@ public IncludeFileFilter(IEnumerable<string> fileNames)
             FileNames = fileNames;
         }
 
-        public bool Filter(string path)
+        public virtual bool Filter(string path)
         {
             return FileNames.Contains(Path.GetFileName(path));
         }

diff --git a/tests/CompilerTest/Input/Filter/ExcludeFileFilterTest.cs b/tests/CompilerTest/Input/Filter/ExcludeFileFilterTest.cs
@@ -28,5 +28,13 @@ public void ItDoesntFilterIfNotMatch()
                 filter.Filter("_TestData/abc/NotFoo.txt")
             );
         }
+
+        [Fact]
+        public void ItOverridesBaseFilter()
+        {
+            Assert.False(
+                ((IFileFilter) filter).Filter("_TestData/abc/Foo.txt")
+            );
+        }
     }
 }