Convert dates back from ISO when parsed #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting data to a JSON values of type VBA.vbDate, datetimes are converted to ISO format, thus adjusting the local time to global time. However, when parsing the same json result back, the time unit stays in global time unit. By adding this line of code the conversion happens both ways. See also extended comment here: VBA-tools#169 (comment)
|
I second this pull request (but I am also not sure if this repository is abandoned as the last commit is 5 years old) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a JSON value of type VBA.vbDate, the time value is converted to ISO format, thus adjusting the local time to global time (adding or substracting a few hours). However, when parsing the same json result back, the time unit stays in global time unit. By adding this line of code the conversion happens both ways. See also extended comment here: #169 (comment)