Fix reference metadata bug

VEuPathDB · May 17, 2024 · 6fc56b2 · 6fc56b2
1 parent 656c409
commit 6fc56b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/main/java/org/veupathdb/service/eda/common/model/EntityDef.java b/src/main/java/org/veupathdb/service/eda/common/model/EntityDef.java
@@ -158,7 +158,7 @@ public String toString() {
   }
 
   public void addVariable(VariableDef variable) {
-    addIfUnique(_categories, EntityChildUniquenessKey::fromVar, variable);
+    addIfUnique(_variables, EntityChildUniquenessKey::fromVar, variable);
   }
 
   public void addCategory(VariableDef category) {

diff --git a/src/main/java/org/veupathdb/service/eda/common/plugin/util/PluginUtil.java b/src/main/java/org/veupathdb/service/eda/common/plugin/util/PluginUtil.java
@@ -63,7 +63,9 @@ private String getCollectionAttribute(Function<CollectionDef, ?> getter, Collect
   }
 
   private String getVariableAttribute(Function<VariableDef, ?> getter, VariableSpec var) {
-    return var == null ? "" : getter.apply(_metadata.getVariable(var).orElseThrow()).toString();
+    return var == null ? "" : getter.apply(_metadata.getVariable(var)
+        .orElseThrow(() -> new IllegalArgumentException(
+            String.format("Unable to find variable with spec %s, %s", var.getEntityId(), var.getVariableId())))).toString();
   }
 
   public String getCollectionType(CollectionSpec collection) {