Code quality feedback #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.1 - e2e test
…in-workflow Remove code duplication in main workflow
Remove commented code
Main -> dev
…tput files (confidential)
Feature/icres based grns
iCREs-based GRN inference feature
Making the iCREs files public with download instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this temporary feedback branch to gather suggestions for polishing mini-AC code quality. This branch has been reverted to the repo's initial commit, to see the entire diff of everything that has been added to the
mainbranch so far since the repo was created. This PR should NOT be merged, it only serves as a place to collect suggestions.I also created a new
dev(develop) branch that is currently in line withmain, on which we can gather all implemented improvements. Each improvement should be implemented on a separate, new branch starting fromdev. We can then use pull requests to merge the improvements todev, with review. All changes gathered ondevshould then be tested on the validation datasets before they are released to themainbranch.