Skip to content

Commit

Permalink
Run size-limit more carefully without fake yarn.lock in packages/vkui
Browse files Browse the repository at this point in the history
We cannot keep using fake yarn.lock because Yarn v3 cannot install
all dependencies properly by having more than one yarn.lock, even
though the second one is fake and empty.
  • Loading branch information
mendrew committed Aug 30, 2023
1 parent c681d31 commit f5625e7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pull_request_packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,10 @@ jobs:
github_token: ${{ secrets.GITHUB_TOKEN }}
# only affects current branch
skip_step: install
directory: packages/vkui/
# В 1.7.0 пока нет этого свойства. См. packages/vkui/yarn.lock
# package_manager: yarn
build_script: 'size:ci'
script: /bin/bash -c "cd packages/vkui && npx size-limit --json"

docs_styleguide_upload:
if: ${{ needs.changed_files.outputs.docs_styleguide == 'true' }}
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@
"playwright:cmd:merge-reports": "playwright merge-reports",
"codesandbox:install": "PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 yarn install",
"deduplicate": "yarn-deduplicate --list && yarn-deduplicate --fail",
"g:npm:version": "cd $INIT_CWD && npm version --no-workspaces-update --no-commit-hooks --no-git-tag-version"
"g:npm:version": "cd $INIT_CWD && npm version --no-workspaces-update --no-commit-hooks --no-git-tag-version",
"size:ci": "cd packages/vkui && yarn run size:ci"
},
"lint-staged": {
"*.{ts,tsx,js,jsx}": [
Expand Down

0 comments on commit f5625e7

Please sign in to comment.