Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button add onClick = noop #6381

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Jan 15, 2024

Добавляем onClick=noop по умолчанию для Button и Link чтобы компонент был кликабельным

@SevereCloud SevereCloud requested a review from a team as a code owner January 15, 2024 12:17
@SevereCloud SevereCloud self-assigned this Jan 15, 2024
@SevereCloud SevereCloud added this to the v6 milestone Jan 15, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 348.02 KB (+0.01% 🔺)
JS (gzip) 106.46 KB (+0.02% 🔺)
JS (brotli) 87.94 KB (-0.09% 🔽)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 256.67 KB (0%)
CSS (gzip) 33.63 KB (0%)
CSS (brotli) 27.34 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f01def5:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit f01def5

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22111f7) 81.26% compared to head (f01def5) 81.29%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6381      +/-   ##
==========================================
+ Coverage   81.26%   81.29%   +0.03%     
==========================================
  Files         326      326              
  Lines       10108    10126      +18     
  Branches     3397     3405       +8     
==========================================
+ Hits         8214     8232      +18     
  Misses       1894     1894              
Flag Coverage Δ
unittests 81.29% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud merged commit 90afa54 into master Jan 15, 2024
27 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/button-add-onClick-=-noop branch January 15, 2024 13:44
@vkcom-publisher
Copy link
Contributor

v6.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants