fix(WriteBarIcon): update missing label warning logic #6385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a5b406c:
|
e2e tests |
👀 Docs deployed
Commit a5b406c |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v5 #6385 +/- ##
==========================================
+ Coverage 80.60% 80.63% +0.02%
==========================================
Files 314 314
Lines 10796 10796
Branches 3364 3364
==========================================
+ Hits 8702 8705 +3
+ Misses 2094 2091 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
removed
patch
github-actions
bot
added
patch
eugpoloz
approved these changes
Jan 16, 2024
|
@mendrew не забудь майлстоун для патча завести, кажется, сейчас его нет у нас. 😉 |
inomdzhon
added
patch
mendrew
deleted the
mendrew/fix/6383/WriteBarIcon/a11y-label-warning-logic
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Jan 17, 2024
Предупреждение о том, что у WriteBarIcon отсутствует текстовое описание выводится даже если текстовое описание есть. В v6 эта проблема решена чуть иначе.
inomdzhon
added
v5
inomdzhon
changed the title
inomdzhon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Предупреждение о том, что у WriteBarIcon отсутствует текстовое описание выводится даже если текстовое описание есть.
В v6 эта проблема решена.
Изменения
ВНИМАНИЕ
У PR базовая ветка v5.