feat(ChipsInputBase): add cycle navigates between chips #6395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Покрыл тестами `ChipsSelect` и `ChipsInputBase`.
size-limit report 📦
|
e2e tests |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0a3d76c:
|
👀 Docs deployed
Commit 0a3d76c |
|
Кста, так и задумано, что в readOnly инпуте нельзя стрелочками навигироваться? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6395 +/- ##
==========================================
+ Coverage 81.37% 81.98% +0.61%
==========================================
Files 327 327
Lines 10140 10134 -6
Branches 3412 3411 -1
==========================================
+ Hits 8251 8308 +57
+ Misses 1889 1826 -63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
force-pushed
the
imirdzhamolov/feat/ChipsInputBase-cycle-navigates
branch
from
fec3dec
to
0a3d76c
Compare
SevereCloud
approved these changes
Jan 23, 2024
inomdzhon
added
the
patch
inomdzhon
deleted the
imirdzhamolov/feat/ChipsInputBase-cycle-navigates
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Jan 23, 2024
h2. Описание
- Добавил цикличную навигацию стрелками между чипами.
https://github.com/VKCOM/VKUI/assets/5850354/a849e56c-9912-4cd3-802a-97f224d9f03b
- Покрыл тестами `ChipsSelect`, `ChipsInputBase`, `Chip`.
- `Chip`
- теперь принимает `readOnly`. При его передаче, скрывается кнопка удаления чипа;
- для корректного произношения скринридером, добавил ` ` перед скрытым текстом `"Удалить <children>"`.
| ✅ v6.0.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавил цикличную навигацию стрелками между чипами.
2024-01-17.19.11.56.mov
Покрыл тестами
ChipsSelect,ChipsInputBase,Chip.ChipreadOnly. При его передаче, скрывается кнопка удаления чипа; перед скрытым текстом"Удалить <children>".ChipsSelectandChipsInput#6367