patch(5.10-stable): pr6373 #6411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6408) В старой реализации CustomSelect (v5.9.3) мы передавали required на div, тем самым он вообще не был задействован в обработке формы. В v5.10.0 мы поломали это поведение и `required` стал передаваться на input, используемый для поиска. Исправляем это передавая `required` на спрятанный нативный селект.
size-limit report 📦
|
e2e tests |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 82bc2f4:
|
👀 Docs deployed
Commit 82bc2f4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.10-stable #6411 +/- ##
===============================================
+ Coverage 80.71% 80.73% +0.01%
===============================================
Files 314 314
Lines 10840 10846 +6
Branches 3381 3386 +5
===============================================
+ Hits 8750 8756 +6
Misses 2090 2090
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
approved these changes
Jan 19, 2024
BlackySoul
approved these changes
Jan 22, 2024
mendrew
deleted the
mendrew/v5.10-stable/patch/c9e8d12a95f203ff31928ab4eba7de907075d743
branch
inomdzhon
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
базовая ветка
5.10-stable. В прошлом PR ошибся с тэгами и5.10-stableне обновилась.Важно
Это cherry-pick из #6373, из v6 в v5.
Описание
В старой реализации CustomSelect (v5.9.3) мы передавали required на div, тем самым он вообще не был задействован в обработке формы. В v5.10.0 мы поломали это поведение и
requiredстал передаваться на input, используемый для поиска.Исправляем это передавая
requiredна спрятанный нативный селект.